[ 
https://issues.apache.org/jira/browse/MAHOUT-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991976#comment-12991976
 ] 

Sean Owen commented on MAHOUT-563:
----------------------------------

I think this could be fine for utils/. There are some style issues with the 
patch (System.out, no copyright, some unused variables, spacing, braces) but 
easily fixed locally. I might sprinkle some javadoc on it too.

I have a few questions:

The variable canopies is never filled out. Should it be removed? Or is this 
supposed to be filled out in estimate()?
There are some constant-looking local variables in estimate(). Can I make them 
constants?



> CanopyEstimator - Estimate T1/T2 for CanopyClusterer
> ----------------------------------------------------
>
>                 Key: MAHOUT-563
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-563
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Clustering
>            Reporter: Lance Norskog
>            Priority: Minor
>         Attachments: MAHOUT-563.patch
>
>
> Hunting for T1/T2 values that make an interesting Canopy set is a singularly 
> unsatisfying task. This class estimates T1 and T2 numbers given the original 
> set.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to