Sean fixed it
On Wed, Apr 6, 2011 at 6:43 AM, Grant Ingersoll <[email protected]> wrote: > Sorry, just seeing this now, did you fix it or do you need me to? > > On Apr 3, 2011, at 6:49 PM, Dmitriy Lyubimov wrote: > >> Grant, filed as MAHOUT-649. Let me know if you want to take it... thanks. >> >> On Sun, Apr 3, 2011 at 3:35 PM, Dmitriy Lyubimov <[email protected]> >> wrote: >>> looks like some assertion there implies unix paths only, not >>> platform-independent. >>> >>> On Sun, Apr 3, 2011 at 3:34 PM, Dmitriy Lyubimov <[email protected]> >>> wrote: >>>> Yes thanks Lance i know. the stack trace shows that some tests had >>>> failures, the same . >>>> >>>> so need to dig into reports, had no time. >>>> >>>> i finally dug into surefire reports and for some reason it's not >>>> cluster test dumper but some other test although it's not reported in >>>> the console. >>>> >>>> org.apache.mahout.text.SequenceFilesFromMailArchivesTest.txt:Tests run: 1, >>>> Failu >>>> res: 1, Errors: 0, Skipped: 0, Time elapsed: 0.144 sec <<< FAILURE! >>>> >>>> the report file >>>> ------------------------------------------------------------------------------- >>>> Test set: org.apache.mahout.text.SequenceFilesFromMailArchivesTest >>>> ------------------------------------------------------------------------------- >>>> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.144 >>>> sec <<< FAILURE! >>>> testMain(org.apache.mahout.text.SequenceFilesFromMailArchivesTest) >>>> Time elapsed: 0.14 sec <<< FAILURE! >>>> org.junit.ComparisonFailure: >>>> expected:<TEST[/subdir/mail-messages.gz/][email protected]> but >>>> was:<TEST[\subdir\mail-messages.gz\][email protected]> >>>> at org.junit.Assert.assertEquals(Assert.java:123) >>>> at org.junit.Assert.assertEquals(Assert.java:145) >>>> at >>>> org.apache.mahout.text.SequenceFilesFromMailArchivesTest.testMain(SequenceFilesFromMailArchivesTest.java:112) >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> at >>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) >>>> at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >>>> at java.lang.reflect.Method.invoke(Method.java:597) >>>> at >>>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) >>>> at >>>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) >>>> at >>>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) >>>> at >>>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) >>>> at >>>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) >>>> at >>>> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) >>>> at >>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76) >>>> at >>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) >>>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) >>>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) >>>> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) >>>> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) >>>> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) >>>> at org.junit.runners.ParentRunner.run(ParentRunner.java:236) >>>> at >>>> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59) >>>> at >>>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:115) >>>> at >>>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:102) >>>> at org.apache.maven.surefire.Surefire.run(Surefire.java:180) >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> at >>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) >>>> at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >>>> at java.lang.reflect.Method.invoke(Method.java:597) >>>> at >>>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350) >>>> at >>>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021) >>>> >>>> >>>> The bisect failed commit info does show this test as modified >>>> $ git log --stat 86e6e1d64901 -1 >>>> commit 86e6e1d64901cc0ce436d43a56fcadb8a2cb6c1d >>>> Author: Grant Ingersoll <[email protected]> >>>> Date: Fri Mar 25 14:39:25 2011 +0000 >>>> >>>> MAHOUT-588: partial commit, not including shell script yet >>>> >>>> git-svn-id: https://svn.apache.org/repos/asf/mahout/trunk@1085408 >>>> 13f79535-4 >>>> >>>> .../text/MailArchivesClusteringAnalyzer.java | 171 +++++++++++ >>>> .../mahout/text/SequenceFilesFromMailArchives.java | 295 >>>> ++++++++++++++++++++ >>>> .../text/MailArchivesClusteringAnalyzerTest.java | 61 ++++ >>>> .../text/SequenceFilesFromMailArchivesTest.java | 214 ++++++++++++++ >>>> 4 files changed, 741 insertions(+), 0 deletions(-) >>>> >>>> Grant, so it all adds up. Not sure why it is not going on my laptop, >>>> it is windows 7, java version >>>> $ java -version >>>> java version "1.6.0_22" >>>> Java(TM) SE Runtime Environment (build 1.6.0_22-b04) >>>> Java HotSpot(TM) 64-Bit Server VM (build 17.1-b03, mixed mode) >>>> >>>> >>>> >>>> >>>> On Wed, Mar 30, 2011 at 2:37 PM, Lance Norskog <[email protected]> wrote: >>>>> Mvn -e shows errors, and --fast-fail means stop immediately. These >>>>> might show the problem. >>>>> >>>>> On Tue, Mar 29, 2011 at 7:27 PM, Dmitriy Lyubimov <[email protected]> >>>>> wrote: >>>>>> i am not sure. it just says running the test and then after a while >>>>>> bails out with 'build failed'. I looked breifly at surefire reports >>>>>> but did not immediately see an error. which makes me think it some >>>>>> sort of maven thing (which is why i asked about maven) >>>>>> >>>>>> Let me follow up on this. >>>>>> >>>>>> On Tue, Mar 29, 2011 at 11:16 AM, Grant Ingersoll <[email protected]> >>>>>> wrote: >>>>>>> What's the error you are getting? >>>>>>> >>>>>>> >>>>>>> On Mar 29, 2011, at 11:28 AM, Dmitriy Lyubimov wrote: >>>>>>> >>>>>>>> Yes I was perplexed as well as i couldnt immediately see a critical >>>>>>>> change >>>>>>>> thhere but I confirmed manually that tests are passing before it and >>>>>>>> failing >>>>>>>> thhere on. >>>>>>>> >>>>>>>> Please don't worry. I highly suspect it is something specicfic to me. >>>>>>>> Just >>>>>>>> thought you might have a quick guess. >>>>>>>> One question though -- which maven version we are 'officially ' using >>>>>>>> for >>>>>>>> this build? >>>>>>>> >>>>>>>> apologies for brevity. >>>>>>>> >>>>>>>> Sent from my android. >>>>>>>> -Dmitriy >>>>>>>> On Mar 29, 2011 8:19 AM, "Grant Ingersoll" <[email protected]> wrote: >>>>>>>>> What's the error you are getting? I don't have ready access to a >>>>>>>>> Windows >>>>>>>> box. >>>>>>>>> >>>>>>>>> Also, I don't believe this commit touched TestClusterDumper. >>>>>>>>> >>>>>>>>> -Grant >>>>>>>>> >>>>>>>>> On Mar 28, 2011, at 11:45 PM, Dmitriy Lyubimov wrote: >>>>>>>>> >>>>>>>>>> Grant, >>>>>>>>>> >>>>>>>>>> these are Bisect results, this commit broke TestClusterDumper in >>>>>>>>>> tests >>>>>>>>>> on windows it seems.. My diagnostic might be wrong but that's what i >>>>>>>>>> got. >>>>>>>>>> >>>>>>>>>> 86e6e1d64901cc0ce436d43a56fcadb8a2cb6c1d is the first bad commit >>>>>>>>>> commit 86e6e1d64901cc0ce436d43a56fcadb8a2cb6c1d >>>>>>>>>> Author: Grant Ingersoll <[email protected]> >>>>>>>>>> Date: Fri Mar 25 14:39:25 2011 +0000 >>>>>>>>>> >>>>>>>>>> MAHOUT-588: partial commit, not including shell script yet >>>>>>>>>> >>>>>>>>>> git-svn-id: >>>>>>>>>> https://svn.apache.org/repos/asf/mahout/trunk@108540813f79535-4 >>>>>>>>>> 7bb-0310-9956-ffa450edef68 >>>>>>>>>> >>>>>>>>>> :040000 040000 2b15021b60e0b772e2195948dddb1dd232a790d0 >>>>>>>> 9b163f5489ec03add7726590 >>>>>>>>>> 13b01c68d86cbaa3 M utils >>>>>>>>>> bisect run success >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Mon, Mar 28, 2011 at 7:57 PM, Dmitriy Lyubimov <[email protected]> >>>>>>>> wrote: >>>>>>>>>>> doesn't pass on my windows laptop anymore. >>>>>>>>>>> >>>>>>>>>>> I am running a bisect now to figure where it started failing but it >>>>>>>>>>> was ok at least 10 commits earlier. Any idea what commit broke it >>>>>>>>>>> and >>>>>>>>>>> why? >>>>>>>>>>> >>>>>>>>>>> I guess I can commit with it being broken still but probably if it >>>>>>>>>>> can >>>>>>>>>>> be fixed it better be. >>>>>>>>>>> >>>>>>>>>>> It also may be because my laptop is running windows (lame i know) >>>>>>>>>>> but >>>>>>>>>>> i'd rather had it fixed on windows too since previously all tests >>>>>>>>>>> worked. >>>>>>>>>>> >>>>>>>>>>> Thanks for any info. >>>>>>>>>>> -Dmitriy >>>>>>>>>>> >>>>>>>>> >>>>>>>>> -------------------------- >>>>>>>>> Grant Ingersoll >>>>>>>>> http://www.lucidimagination.com/ >>>>>>>>> >>>>>>>>> Search the Lucene ecosystem docs using Solr/Lucene: >>>>>>>>> http://www.lucidimagination.com/search >>>>>>>>> >>>>>>> >>>>>>> -------------------------- >>>>>>> Grant Ingersoll >>>>>>> http://www.lucidimagination.com/ >>>>>>> >>>>>>> Search the Lucene ecosystem docs using Solr/Lucene: >>>>>>> http://www.lucidimagination.com/search >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Lance Norskog >>>>> [email protected] >>>>> >>>> >>> > > -------------------------- > Grant Ingersoll > Lucene Revolution -- Lucene and Solr User Conference > May 25-26 in San Francisco > www.lucenerevolution.org > >
