I think I need to make fastinstall use maven.test.skip instead of what it uses now.
On Thu, Apr 7, 2011 at 5:37 PM, Dmitriy Lyubimov <[email protected]> wrote: > by compilation i meant 'mvn clean install -Dmaven.test.skip=true' > > > On Thu, Apr 7, 2011 at 2:20 PM, Lance Norskog <[email protected]> wrote: >> 'mvn package' and 'mvn install' run the tests. They also make the >> jars. 'compile' only makes .class files, no jars. I think; Maven is >> pretty opaque. >> >> On Thu, Apr 7, 2011 at 2:06 PM, Dmitriy Lyubimov <[email protected]> >> wrote: >>> Second that. I can compile it without running tests. As long as >>> test-jar in the test scope, it is not needed to compile . >>> >>> Given there are no problems with compile (and i can't seem to confirm >>> there are) there's no need to include test-specific support into >>> production runtime since it never intended to run there. >>> >>> -d >>> >>> On Thu, Apr 7, 2011 at 1:41 PM, Sean Owen <[email protected]> wrote: >>>> Can you -DskipTests or is that a hack? That's what I do when I don't want >>>> tests. >>>> >>>> There are 4 MahoutTestCases, one for each module. 3 of them depends on the >>>> 4th in math. It's tidy insofar as it lets the tests share some non-trivial >>>> logic about file cleanup and random numbers. >>>> >>>> Is it worse to make a new module or just copy-and-paste this code around >>>> the >>>> 3 modules? I'd say copy and paste sounds less annoying actually. >>>> >>>> >>>> Stepping back -- is it true that building the project means running tests? >>>> I >>>> ran "mvn clean compile" just now and no tests ran. What am I missing? >>>> Naively, it seems OK that core depends on math and core tests depend on >>>> math >>>> tests. >>>> >>>> >>>> On Thu, Apr 7, 2011 at 9:28 PM, Benson Margulies >>>> <[email protected]>wrote: >>>> >>>>> test-jar is generally evil. I'm sure that remark is not especially >>>>> helpful, but pretty much everyone who touches it that I've ever heard >>>>> of regrets it. >>>>> >>>>> Practically for mahout, you can't grab a source tree and to mvn >>>>> -Pfastinstall. You have to sit through running all the tests. >>>>> >>>>> Now, I could fix fastinstall to use the finer-grained options that >>>>> keep test compilation and just suppress test running, I confess. But >>>>> my first instinct was to squash the use of test-jar altogether. If you >>>>> all cluster 'round and express a preference in the direction of >>>>> keeping test-jar, I'll make the other fix. >>>>> >>>>> And, yes, MahoutTestCase may be the singular item that causes all this >>>>> grief. >>>>> >>>>> Unfortunately, since it extends 'Assert', my 'proposal (3)' doesn't >>>>> work. We need a jar file that contains RandomUtils, and then we need a >>>>> jar file that contains MahoutTestCase. Ouch. >>>>> >>>>> Even I am beginning to think that the profile fix is preferable. >>>>> >>>>> On Thu, Apr 7, 2011 at 4:19 PM, Sean Owen <[email protected]> wrote: >>>>> > What's the problem being solved here? it all works OK to me. >>>>> > My guess is there's not a need to create a super-core nameless toplevel >>>>> > module just for this. Are we talking about MahoutTestCase? >>>>> > >>>>> > On Thu, Apr 7, 2011 at 4:27 PM, Benson Margulies <[email protected]> >>>>> > wrote: >>>>> >> >>>>> >> The use of test-jar leads to problems, notably that you can't build >>>>> >> the complete tree from clean without getting tangled up with tests. I >>>>> >> propose to make more directories in the top level to contain the >>>>> >> common test classes that are currently in the test-jars. This is two >>>>> >> new dirs, one for math and one for core. >>>>> >> >>>>> >> Do people want prior review of this on a JIRA? >>>>> > >>>>> > >>>>> >>>> >>> >> >> >> >> -- >> Lance Norskog >> [email protected] >> >
