Yeah that's right, I think I must have removed it by mistake then. I believe I fixed one warning where the issues was fixable with better generics syntax. But some of the Hadoop classes aren't declared quite right so it's not fixable at this point. If that's the case, put back the annotation (or which class is it? I'll put it back).
On Sun, Apr 17, 2011 at 6:13 PM, Dmitriy Lyubimov <[email protected]> wrote: > Sean, > I noticed you removed @SuppressWarnings annotations. > > As a result, there's a bunch of warnings in the SSVD code. > I normally check all warnings and _usually_ warnings are justified and > helpful to find bugs proactively. > > In relatively rare cases when warnings are justified (thus as a lot of > instances in hadoop when their styling forces generics warnings, i > reset them with @SuppressWarnings to signal they are validated to be > o.k. in this cases. > > But if you remove those, this is quite unfortunate. This masks real > warnings that need to be checked or forces me to do scan for warnings > where i already did that. > > What gives? >
