[ 
https://issues.apache.org/jira/browse/MAHOUT-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021914#comment-13021914
 ] 

Lance Norskog commented on MAHOUT-676:
--------------------------------------


bq. All fields ought to be private here
Yes.
bq. Is there a need for "stop()" really?
Needs a flush() instead of stop().
bq. Instead of dealing with null samples everywhere, just set it to an initial 
empty list
Changing it to flush() needs this.
bq. The list should probably be LinkedList if it's going to have elements 
removed off the front
Yes! It's a fifo.



> Random samplers in a modular library
> ------------------------------------
>
>                 Key: MAHOUT-676
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-676
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Math
>            Reporter: Lance Norskog
>            Priority: Minor
>         Attachments: Sampler.patch
>
>
> This is a modular suite of samplers.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to