[ 
https://issues.apache.org/jira/browse/MAHOUT-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023249#comment-13023249
 ] 

Sean Owen commented on MAHOUT-678:
----------------------------------

Tiny suggestion: I bet you'll find that "hasOne = actual == 1;" is actually 
very marginally faster than the if statement (avoids a branch) and is a bit 
more compact. I also dont know enough to say whether this is the right change. 

> NullPointerException while using MixedGradient with SGD algorithm
> -----------------------------------------------------------------
>
>                 Key: MAHOUT-678
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-678
>             Project: Mahout
>          Issue Type: Bug
>          Components: Classification
>    Affects Versions: 0.5
>            Reporter: Stanley Xu
>         Attachments: nullpointerexceptionbugfix.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I am trying to use the MixedGradient in OnlineLogisticRegression algorithm. 
> But I will get an NullPointerException randomly if I set the alpha larger 
> than 0. 
> I checked the code and found that in the RankingGradient used by 
> MixedGradient, it assume that the target category should be only 2, rather 
> than multiple. And the rank gradient should only be used once the Gradient 
> object knew both the positive and negative targets. I created a simple patch 
> to make it workable, but I am not really understand the MixedGradient method 
> deeply, please check the patch carefully to see if it really works correctly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to