[
https://issues.apache.org/jira/browse/MAHOUT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044327#comment-13044327
]
Sean Owen commented on MAHOUT-696:
----------------------------------
I will post my own version of your last patch. There are a number of style
issues with it.
This seems like a lot of copy-and-paste. Is this necessary?
- Name your patch like MAHOUT-XXX.patch
- All files need an Apache license header
- Don't make your own ArgumentException; use IllegalArgumentException
- doubleValue == Double.NaN is always false; you mean Double.isNaN()
- All control flow statements need braces
- Watch redundant assignment to null
- Generally watch spacing and code formatting; this doesn't match the rest of
the code base
- You usually write "foo == null" rather than "null == foo"; this isn't C
> Command line program for AdaptiveLogiscticRegression
> ----------------------------------------------------
>
> Key: MAHOUT-696
> URL: https://issues.apache.org/jira/browse/MAHOUT-696
> Project: Mahout
> Issue Type: Improvement
> Components: Classification
> Affects Versions: 0.5
> Reporter: XiaoboGu
> Fix For: 0.6
>
> Attachments: MAHOUT-696.patch, mahout-696-r1.patch,
> mahout-696-r2.patch, mahout-696-r3.patch, mahout-696-r4.patch,
> mahout-696-r5.patch
>
>
> Suggested by Ted, I'll try to write a command line program for
> AdaptiveLogicticRegression, but as I am not familir with the algorithm, I'll
> try to write a prototype for the program from a Java developer's perspactive,
> hope anyone else will help with the details of the algorithm.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
