[ 
https://issues.apache.org/jira/browse/MAHOUT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158478#comment-13158478
 ] 

Sean Owen commented on MAHOUT-901:
----------------------------------

Sounds good, I generally trust you've investigated this and tested it -- any 
chance you have a unit test that just shows it outputs what you expect on a 
tiny data set? You can copy and paste others.

The code needs some formatting changes but I can do that. THe only line I 
question is the "catch (Exception)" bit -- should this not be replaced with 
bounds checking?
                
> KnnItemBasedRecommender is not working properly
> -----------------------------------------------
>
>                 Key: MAHOUT-901
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-901
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Georgi Stanev
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.6
>
>         Attachments: KnnItemBasedRecommender_new.java
>
>
> For more information see the mailing list archive (KnnItemBasedRecommender 
> question)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to