[ https://issues.apache.org/jira/browse/MAHOUT-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160739#comment-13160739 ]
jirapos...@reviews.apache.org commented on MAHOUT-880: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2955/ ----------------------------------------------------------- (Updated 2011-12-01 08:39:37.868935) Review request for Ted Dunning, Jake Mannix and Sebastian Schelter. Changes ------- A fair bit of refactoring. Added plus() and minus() methods for Matrix-Matrix and Matrix-Vector combinations. Renamed MatrixCovarianceJob() to TimesSelfJob() to improve clarity per Sebastian's suggestion. Moved vector argument to distributed cache and changed class to Vector per Jake's suggestion. Removed MatrixRowAverageJob.java for now. Summary ------- Jobs for matrix-vector addition, covariance matrix calculation and row average calculation in DistributedRowMatrix This addresses bug MAHOUT-880. https://issues.apache.org/jira/browse/MAHOUT-880 Diffs (updated) ----- trunk/core/src/main/java/org/apache/mahout/math/hadoop/DistributedRowMatrix.java 1206431 trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixMatrixElementwiseJob.java PRE-CREATION trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixVectorElementwiseJob.java PRE-CREATION trunk/core/src/main/java/org/apache/mahout/math/hadoop/TimesSelfJob.java PRE-CREATION trunk/core/src/test/java/org/apache/mahout/math/hadoop/TestDistributedRowMatrix.java 1206431 Diff: https://reviews.apache.org/r/2955/diff Testing ------- Junit tests for each job Thanks, Raphael > Add some matrix method(like addition, subtraction, norm ... etc) to > DistributedRowMatrix > ---------------------------------------------------------------------------------------- > > Key: MAHOUT-880 > URL: https://issues.apache.org/jira/browse/MAHOUT-880 > Project: Mahout > Issue Type: New Feature > Components: Math > Affects Versions: 0.6 > Reporter: Wangda Tan > Priority: Minor > Labels: DistributedRowMatrix > Attachments: MAHOUT-880.patch > > > I'm a new to Mahout, I didn't find some basic matrix functions. This make > users cannot do many tasks by CLI or API, if user get some result through > existing map-reduce matrix operation (like svd), he cannot do farther steps. > I make a list for it: > 1) Addition, Subtraction > 2) Norm (like norm-1, norm-2, norm-frobenius) > 3) Matrix compare > 4) Get lower triangle, upper triangle and diagonal > 5) Get identity and zero matrix > 6) Put two or matrix to together: A = [A1, A2] > 7) More linear equations solver method, like Gaussian elimination (maybe it's > hard to implement) > 8) import and export CSV, ARFF ... (this will very useful when user want to > reuse result from or to other applications like MATLAB) > I want to know is there any plan to do this, if so, I can make some efforts > to implement these. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira