[
https://issues.apache.org/jira/browse/MAHOUT-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168370#comment-13168370
]
jirapos...@reviews.apache.org commented on MAHOUT-918:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3072/#review3875
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java
<https://reviews.apache.org/r/3072/#comment8703>
Direct and exact quotes from the paper should be either avoided or
acknowledged. Better here to rephrase the language.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java
<https://reviews.apache.org/r/3072/#comment8704>
Again, just quoting the paper is not a good idea. This isn't adding any
information in any case since the exact same language was used in the class
level java doc.
It would be nice here to note that the average is an *unweighted* average.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java
<https://reviews.apache.org/r/3072/#comment8705>
I don't think that this is correct. Is this really what the output is?
Why are you dividing by a weight vector? How do you compute this score?
Or do you mean to not divide here?
If so, why do you use a score as the key?
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java
<https://reviews.apache.org/r/3072/#comment8706>
This looks like a bad key to use here.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionReducer.java
<https://reviews.apache.org/r/3072/#comment8707>
I don't think that this is correct. In the google paper, the average was
unweighted. In any case how do you compute this score for weighting?
Also, if the key is the score, how does the reducer work since each reduce
function will only see one score? Are you assuming that there is exactly one
reducer?
- Ted
On 2011-12-13 07:32:38, issei yoshida wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3072/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-13 07:32:38)
bq.
bq.
bq. Review request for mahout.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. MAHOUT-918 Parallelized SGD in MapReduce
bq.
bq.
bq. This addresses bug MAHOUT-918.
bq. https://issues.apache.org/jira/browse/MAHOUT-918
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/PassiveAggressive.java
1213193
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionReducer.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionDriver.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionMapper.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionReducer.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveDriver.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveMapper.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveReducer.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDDriver.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDMapper.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDReducer.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapReduceTest.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionMapReduceTest.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveMapReduceTest.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/SGDMapReduceTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3072/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. issei
bq.
bq.
> Implement SGD based classifiers using MapReduce
> -----------------------------------------------
>
> Key: MAHOUT-918
> URL: https://issues.apache.org/jira/browse/MAHOUT-918
> Project: Mahout
> Issue Type: New Feature
> Components: Classification
> Affects Versions: 0.6
> Reporter: issei yoshida
> Attachments: MAHOUT-918.patch, design.pdf
>
>
> Implement SGD based classifiers (Logistic Regression, Adaptive Logistic
> regression and Passive-Aggressive) using MapReduce.
> They are implemented using Iterative Parameter Mixtures algorithm which is
> referred to in the following papers.
> http://research.google.com/pubs/pub36948.html
> http://aclweb.org/anthology-new/N/N10/N10-1069.pdf
> http://books.nips.cc/papers/files/nips22/NIPS2009_0345.pdf
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
