----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3072/#review3875 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java <https://reviews.apache.org/r/3072/#comment8703> Direct and exact quotes from the paper should be either avoided or acknowledged. Better here to rephrase the language. trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java <https://reviews.apache.org/r/3072/#comment8704> Again, just quoting the paper is not a good idea. This isn't adding any information in any case since the exact same language was used in the class level java doc. It would be nice here to note that the average is an *unweighted* average. trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java <https://reviews.apache.org/r/3072/#comment8705> I don't think that this is correct. Is this really what the output is? Why are you dividing by a weight vector? How do you compute this score? Or do you mean to not divide here? If so, why do you use a score as the key? trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java <https://reviews.apache.org/r/3072/#comment8706> This looks like a bad key to use here. trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionReducer.java <https://reviews.apache.org/r/3072/#comment8707> I don't think that this is correct. In the google paper, the average was unweighted. In any case how do you compute this score for weighting? Also, if the key is the score, how does the reducer work since each reduce function will only see one score? Are you assuming that there is exactly one reducer? - Ted On 2011-12-13 07:32:38, issei yoshida wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3072/ > ----------------------------------------------------------- > > (Updated 2011-12-13 07:32:38) > > > Review request for mahout. > > > Summary > ------- > > MAHOUT-918 Parallelized SGD in MapReduce > > > This addresses bug MAHOUT-918. > https://issues.apache.org/jira/browse/MAHOUT-918 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/PassiveAggressive.java > 1213193 > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionDriver.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapper.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionReducer.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionDriver.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionMapper.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionReducer.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveDriver.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveMapper.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveReducer.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDDriver.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDMapper.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/mahout/classifier/sgd/mapreduce/SGDReducer.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/AdaptiveLogisticRegressionMapReduceTest.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/LogisticRegressionMapReduceTest.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/PassiveAggressiveMapReduceTest.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/mahout/classifier/sgd/mapreduce/SGDMapReduceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3072/diff > > > Testing > ------- > > > Thanks, > > issei > >
