[
https://issues.apache.org/jira/browse/MAHOUT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204866#comment-13204866
]
Hudson commented on MAHOUT-948:
-------------------------------
Integrated in Mahout-Quality #1344 (See
[https://builds.apache.org/job/Mahout-Quality/1344/])
MAHOUT-948 better error for bad type
srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242333
Files :
*
/mahout/trunk/integration/src/main/java/org/apache/mahout/utils/vectors/arff/MapBackedARFFModel.java
> Improved error reporting when ARFF index does not exist in arff.vector [fix
> provided]
> -------------------------------------------------------------------------------------
>
> Key: MAHOUT-948
> URL: https://issues.apache.org/jira/browse/MAHOUT-948
> Project: Mahout
> Issue Type: Improvement
> Components: Integration
> Environment: I just pulled the latest from SVN today (01/17/2012)
> Reporter: Stuart Smith
> Assignee: Sean Owen
> Priority: Trivial
> Labels: patch
> Fix For: 0.7
>
> Attachments: MapBackedARFFModel.java
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> MapBackedARFFModel throws an NPE when getValue is passed an idx for an
> attribute that does not exist.
> In short, this:
> <code>
> public double getValue(String data, int idx) {
> ARFFType type = typeMap.get(idx);
> data = QUOTE_PATTERN.matcher(data).replaceAll("");
> data = data.trim();
> double result;
> if( type == null ) {
> throw new IllegalStateException( "Attribute type cannot be NULL,
> attribute index was: " + idx );
> }
> switch (type) {
> case NUMERIC:
> result = processNumeric(data);
> </code>
> Is better than this:
> <code>
> public double getValue(String data, int idx) {
> ARFFType type = typeMap.get(idx);
> data = QUOTE_PATTERN.matcher(data).replaceAll("");
> data = data.trim();
> double result;
> switch (type) {
> case NUMERIC:
> result = processNumeric(data);
> </code>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
