[
https://issues.apache.org/jira/browse/MAHOUT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288261#comment-13288261
]
Ted Dunning commented on MAHOUT-768:
------------------------------------
I think that there may be some users of collections out there somewhere that we
don't know about so I didn't want to delete it completely. We should be able
to get the jenkins build to not care about it.
I think you may be right about the clover stuff or something like that. I
think that there is a build and test done once normally and then again with
some kind of profiling (aka clover) or analysis (findbugs or some such). The
second build seems to be confused and is somehow winding up with two copies of
collections. It could be that I didn't change the dependency correctly or it
could be that the instrumentation is not interacting well with the idea of the
code generation that occurs with collections. This could be the fault of the
code generation plug-in (not surprising if so) or the instrumentation framework
may be confusing things by doing its own thing with code modification on top of
code generation.
In any case, I am not convinced at all that the collections project has
anything to do with the problem.
One good strategy would be to turn off the code coverage and quality phases
temporarily. If this cures the problem, then we know something. My next step
would be to insert a mvn clean somewhere between the first test build and the
instrumentation build or to simply delete the primary test build. If the
instrumentation works without the primary build or if the clean fixes things,
then we know one more thing.
> Duplicated DoubleFunction in mahout and mahout-collections (mahout.math
> package).
> ---------------------------------------------------------------------------------
>
> Key: MAHOUT-768
> URL: https://issues.apache.org/jira/browse/MAHOUT-768
> Project: Mahout
> Issue Type: Improvement
> Components: collections, Math
> Affects Versions: 0.5, collections-1.0
> Reporter: Dawid Weiss
> Assignee: Ted Dunning
> Priority: Minor
> Fix For: 0.7
>
>
> DoubleFunction is duplicated in Mahout Math and Collections. There are also
> other things inside m.math.* package that are kept there to avoid circular
> dependencies... Simply removing DoubleFunction from collections is not going
> to work because it is needed for compilation (again, circular dependency
> between collections and math). I see two solutions:
> 1) extract the common definitions inside math.function.* into a separate
> module. This is a clean solution, but obviously scatters the code even
> further.
> 2) create a compilation-time, optional dependency on mahout 0.5 in
> collections, remove the entire mahout.math.* subpackage from collections and
> live with this. I don't know how Maven handles circular dependencies of this
> type:
> collections [trunk] -> [optional, required at build time] mahout.math 0.5
> mahout.math [trunk] -> collections [trunk]
> it seems tricky and error-prone, but should also work.
> Looking for other ideas of cleaning this mess up, of course.
> Dawid
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
