[
https://issues.apache.org/jira/browse/MAHOUT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664918#comment-13664918
]
Dawid Weiss commented on MAHOUT-1225:
-------------------------------------
No, this is not the right fix, Tom. That loop is correct as open addressing
allows a "wrap around" in the array and this "if" clause does exactly that. The
problem is the invariant of indexOf (and other methods in open addressing) is
that there is at least one empty slot, which is not the case due to the bug I
mentioned.
> Sets and maps incorrectly clear() their state arrays (potential endless loops)
> ------------------------------------------------------------------------------
>
> Key: MAHOUT-1225
> URL: https://issues.apache.org/jira/browse/MAHOUT-1225
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Affects Versions: 0.7
> Environment: Eclipse, linux Fedora 17, Java 1.7, Mahout Maths
> collections (Set) 0.7, hppc 0.4.3
> Reporter: Sophie Sperner
> Assignee: Dawid Weiss
> Labels: hashset, java, mahout, test
> Fix For: 0.7
>
> Attachments: hppc-0.4.3.jar, mushroom.dat
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The code I attached hangs on forever, Eclipse does not print me its stack
> trace because it does not terminate the program. So I decided to make a small
> test.java file that you can easily run.
> This code has the main function that simply runs getItemList() method which
> successfully executes getDataset() method (here please download mushroom.dat
> dataset and set the full path into filePath string variable) and the hangs on
> (the problem happens on a fourth columnValues.add() call). After the dataset
> was taken into X array, the code simply goes through X column by column and
> searches for different items in it.
> If you uncomment IntSet columnValues = new IntOpenHashSet(); and
> corresponding import headers then everything will work just fine (you will
> also need to include hppc jar file found here
> http://labs.carrotsearch.com/hppc.html or below in the attachment).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
