Hi,

i created an extension of the feature vector encoder framework that allows
for byte array offset and length to be passed in . Some questions remain
before creating an issue and attaching a diff:


1. When using "Sun Conventions" with 2 spaces (the link is broken by the
way), which line length to choose? I'm using eclipse and my code looks
somewhat different with the 80 char line length

2. I extended all existing methods that take an byte[] array to also take
offset and length, the old byte[] methods stay the same. After implementing

public void addInteractionToVector(byte[] originalForm1, int offset1,
intlength1,
byte[] originalForm2, int offset2, int length2, double weight, Vector data)

i thought it would me maybe smarter to user ByteBuffer for passing in the
byte array, offset and positions. A ByteBuffer is created EVERY time inside
the MurmurHash class anyway so it wouldn't produce any more objects. Any
comments / wishes?


Cheers,


Johannes

Reply via email to