[ 
https://issues.apache.org/jira/browse/MAHOUT-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672511#comment-13672511
 ] 

Sean Owen commented on MAHOUT-1211:
-----------------------------------

PS I would suggest that it's OK to swallow the exception when closing a 
*reader* fails, but ideally not when a *writer* fails. This may not be the case 
already, everywhere. 
The idea is that if you can't clean up after you've fully read a stream, 
there's not much you can do but proceed. But failing after fully writing to a 
stream might be bad since it could be a failure to flush buffered data.
                
> Replace deprecated Closables.closeQuietly calls
> -----------------------------------------------
>
>                 Key: MAHOUT-1211
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1211
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Stevo Slavic
>            Assignee: Ted Dunning
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: MAHOUT-1211.patch
>
>
> Deprecated Guava {{Closables.closeQuietly}} API has to be replaced, it's 
> usage is a code smell, and that method is scheduled to be removed from Guava 
> 16.0.
> See [this 
> discussion|https://code.google.com/p/guava-libraries/issues/detail?id=1118] 
> for more info.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to