[ 
https://issues.apache.org/jira/browse/MAHOUT-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702344#comment-13702344
 ] 

Saleem Ansari commented on MAHOUT-1193:
---------------------------------------

Hello Ted,

I have fixed the test cases. The central issue to the problem was that the 
class members "rows" and "columns" were conflicting with the parent class 
members ( AbstractMatrix ).

That fixed all test cases except two:
 * testClone() -- this failed because of missing clone() method 
 * testViewColumnIndexOver() -- this was failing because BlockSparseMatrix have 
extensible rows

I have added clone() method and also fixed remaining test cases in 
BlockSparseMatrixTest class.

Now all tests are passing. Please have a look at the patch attached in previous 
comment: [^MAHOUT-1193-all-tests-pass.patch]


Thanks,
Saleem

                
> We may want a BlockSparseMatrix
> -------------------------------
>
>                 Key: MAHOUT-1193
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1193
>             Project: Mahout
>          Issue Type: Bug
>            Reporter: Ted Dunning
>             Fix For: Backlog
>
>         Attachments: MAHOUT-1193-all-tests-pass.patch, 
> MAHOUT-1193-fix-compile-errors-tests-still-fail.patch, MAHOUT-1193.patch
>
>
> Here is an implementation.
> Is it good enough to commit?
> Is it useful?
> Is it redundant?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to