[
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788083#comment-13788083
]
Dawid Weiss commented on MAHOUT-1345:
-------------------------------------
This looks good, Isabel! Just for the sake of clarity -- perhaps it'll be
useful for others:
{code}
executor.awaitTermination(10, TimeUnit.SECONDS);
...
executor.shutdown();
{code}
The executors framework in Java doesn't wait for any threads it creates to die
(even after the executor is shutdown) and the the test framework will check for
any remaining threads right after the test is over (and fail if there are any).
To add some "slack time" to allow any spawned threads to die, you can use
ThreadLeakLingering (and I see that you already do use this in certain cases).
In Lucene/Solr this is sort of handled by having a separate top-level class
from which all test suites inherit, all annotations configuring the framework
are defined there.
> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
> Key: MAHOUT-1345
> URL: https://issues.apache.org/jira/browse/MAHOUT-1345
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Isabel Drost-Fromm
> Priority: Minor
> Fix For: 0.9
>
> Attachments: MAHOUT-1345.diff
>
>
> When enabling randomised testing for all modules I found a few tests became
> unstable or even fail deterministically due to lingering threads. The
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads
> for me on my machine. I'd greatly appreciate input a) from those who wrote
> the respective code and b) others who ran the tests with these changes to
> make sure there are no other tests that suffer from the same issues.
> Warning: I touched quite a few bits and pieces I'm not intimately familiar
> with over the last few weeks (whenever I had a few spare minutes) - second
> pair of eyes needed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
