[
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831224#comment-13831224
]
Frank Scholten commented on MAHOUT-1345:
----------------------------------------
[~isabel] The threads I am talking about are the map tasks themselves, part of
the lucene2seq MR job. The initialize method of the RecordReader throws an
exception due to the invalid query, which is correct because that is what we
are testing. However this exception runs after the map tasks are created. A
Hadoop job can be aborted by throwing an exception in the RecordReader but this
does not properly clean up the map task threads before the JUnit test exits. So
my question is what's the Hadoop way of cleaning up these map tasks when the
RecordReader cannot continue, in this case because of an invalid query.
[~smarthi] I see I can get the job ID via the context but dont't know how to
get to the Job. On the other hand, like [~dweiss] said, maybe we should not
check thread leaks at all in this particular testcase.
> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
> Key: MAHOUT-1345
> URL: https://issues.apache.org/jira/browse/MAHOUT-1345
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Isabel Drost-Fromm
> Priority: Minor
> Fix For: 0.9
>
> Attachments: MAHOUT-1345.diff, MAHOUT-1345.patch
>
>
> When enabling randomised testing for all modules I found a few tests became
> unstable or even fail deterministically due to lingering threads. The
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads
> for me on my machine. I'd greatly appreciate input a) from those who wrote
> the respective code and b) others who ran the tests with these changes to
> make sure there are no other tests that suffer from the same issues.
> Warning: I touched quite a few bits and pieces I'm not intimately familiar
> with over the last few weeks (whenever I had a few spare minutes) - second
> pair of eyes needed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
