[
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836143#comment-13836143
]
Suneel Marthi commented on MAHOUT-1345:
---------------------------------------
[~dweiss] Added the annotations per MahoutTestCase as suggested by you. There
was another random failure reported by Hudson :
{Code}
Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.935 sec <<<
FAILURE! - in
org.apache.mahout.cf.taste.impl.recommender.svd.ALSWRFactorizerTest
toyExampleImplicit(org.apache.mahout.cf.taste.impl.recommender.svd.ALSWRFactorizerTest)
Time elapsed: 0.114 sec <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from TEST
scope at
toyExampleImplicit(org.apache.mahout.cf.taste.impl.recommender.svd.ALSWRFactorizerTest):
1) Thread[id=49, name=pool-10-thread-4, state=RUNNABLE,
group=TGRP-ALSWRFactorizerTest]
at sun.misc.Unsafe.unpark(Native Method)
at java.util.concurrent.locks.LockSupport.unpark(LockSupport.java:122)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.unparkSuccessor(AbstractQueuedSynchronizer.java:640)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1242)
at
java.util.concurrent.locks.ReentrantLock.unlock(ReentrantLock.java:431)
at
java.util.concurrent.ThreadPoolExecutor.workerDone(ThreadPoolExecutor.java:1023)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:922)
at java.lang.Thread.run(Thread.java:662)
at
__randomizedtesting.SeedInfo.seed([A5759B90EF18631F:5EA19EC521877CAD]:0)
{Code}
Hopefully, the fix suggested by you should take care of all these random
failures.
> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
> Key: MAHOUT-1345
> URL: https://issues.apache.org/jira/browse/MAHOUT-1345
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Isabel Drost-Fromm
> Assignee: Suneel Marthi
> Priority: Minor
> Fix For: 0.9
>
> Attachments: MAHOUT-1345.diff, MAHOUT-1345.patch
>
>
> When enabling randomised testing for all modules I found a few tests became
> unstable or even fail deterministically due to lingering threads. The
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads
> for me on my machine. I'd greatly appreciate input a) from those who wrote
> the respective code and b) others who ran the tests with these changes to
> make sure there are no other tests that suffer from the same issues.
> Warning: I touched quite a few bits and pieces I'm not intimately familiar
> with over the last few weeks (whenever I had a few spare minutes) - second
> pair of eyes needed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
