[ https://issues.apache.org/jira/browse/MAHOUT-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930725#comment-13930725 ]
Sebastian Schelter commented on MAHOUT-1447: -------------------------------------------- Its clear know, I didn't had the getters for hiding the mapping as you assumed. I think the methods from your patch are fine. I'm committing your patch with a few cosmetic changes. Btw, are you interesting in contributing the cross-validation code? :) > ImplicitFeedbackAlternatingLeastSquaresSolver tests and features > ---------------------------------------------------------------- > > Key: MAHOUT-1447 > URL: https://issues.apache.org/jira/browse/MAHOUT-1447 > Project: Mahout > Issue Type: Improvement > Components: Collaborative Filtering > Affects Versions: 0.9 > Reporter: Adam Ilardi > Assignee: Sebastian Schelter > Priority: Minor > Labels: newbie, patch, performance > Fix For: 1.0 > > Attachments: MAHOUT-1447.patch > > > I added a test case for the YtY calculation code > I removed the indexes.quickSort() in the YtY calculation because I don't > think it's necessary and the test cases passed without it. The order > shouldn't matter since you're adding the scalers together. Correct me if i'm > wrong. > In Factorization.java I added methods to access the iterator of item ids and > user ids directly. This saves memory when using classes like TopItems.java > when you don't have the DataModel class in memory as well. -- This message was sent by Atlassian JIRA (v6.2#6252)