Yes, this is a very important part of the workflow that we're having trouble with/ignoring via reviewboard and svn.
On Thu, May 15, 2014 at 12:40 PM, Dmitriy Lyubimov <[email protected]>wrote: > Yes, and no. > > Yes, committers should be able to push, or, rather, merge pull requests. > But in case committers are also acting as contributors, i'd expect a pull > request to be filed, since it is more than just this. It is also a review > board. I've been struggling with integration issues in apache review board, > and it seems, not just me alone. Github reviews are nicely integrated, it > is a nice way to collaborate. Instead of cluttering jira, we could just > discuss details right on the PR and be very specific about points of code > we are talking to. > > > On Fri, May 9, 2014 at 4:17 PM, Pat Ferrel <[email protected]> wrote: > > > Yes! I mentioned this awhile back. Pull requests are just patches under > > the covers, just soo easy to create. > > > > But pull requests would just be for contributors, right? Committers > should > > be able to push to the master directly, right? > > > > On May 6, 2014, at 6:39 PM, Dmitriy Lyubimov <[email protected]> wrote: > > > > Hi, > > > > We are trying to explore an option of moving Mahout to GIT as its main > > repository. What are the options to do this within current infrastucture? > > > > How will we be able to do github pull requests similar to how Apache > Spark > > does it? > > > > Thank you. > > -Dmitriy > > > > >
