[ https://issues.apache.org/jira/browse/MAHOUT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-1385: --------------------------------------- Resolution: Fixed Status: Resolved (was: Patch Available) I agree, Johannes is right that ideally we would want to leverage hashcode caching of Strings. But the current code is a non-working implementation, which this patch fixes. So I'm committing this for now. > Caching Encoders don't cache > ---------------------------- > > Key: MAHOUT-1385 > URL: https://issues.apache.org/jira/browse/MAHOUT-1385 > Project: Mahout > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Johannes Schulte > Priority: Minor > Fix For: 1.0 > > Attachments: MAHOUT-1385-test.patch, MAHOUT-1385.patch > > > The Caching... line of encoders contains code of caching the hash code terms > added to the vector. However, the method "hashForProbe" inside this classes > is never called as the signature has String for the parameter original form > (instead of byte[] like other encoders). > Changing this to byte[] however would lose the java String internal caching > of the Strings hash code , that is used as a key in the cache map, triggering > another hash code calculation. -- This message was sent by Atlassian JIRA (v6.2#6252)