I’m confused about the workflow.
It looks like you keep two local repos one pointed to your fork on github, the
other to git-wip-us. Do your work on your repo (set git-wip-us as upstream to
get updates) and when you want to merge do “git request-pull branch
url-to-git-wip-us". This will package an uber patch from your repo and
communicate with the destination server (I assume). But how do you receive the
notification and respond?
I’ve never responded to a PR outside of Github, and there was no notification
that the PR had been issued outside of the Github UI.
On May 25, 2014, at 10:24 AM, Dmitriy Lyubimov <dlie...@gmail.com> wrote:
jeninkins: mahout-nightly seems to be running ok off new git.
can't get mahout-quality to run thru still. it was failing in execution of
Jenkins findBugs publishing plugin, i've desabled this plugin for the time
being. Still however couldn't get it run once successfully so far.
On Sun, May 25, 2014 at 9:40 AM, Dmitriy Lyubimov <dlie...@gmail.com> wrote:
> INFRA-7801 is now complete. all apache-github PR functionality is now
> enabled.
>
> note that (as far as i understand) cannot merge PRs directly into github
> mirror (since it is a mirror and thus read-only). We will have to merge PRs
> into git-wip-us as described here [2] "merging locally" and here [3]
>
> Note that [3] also applicable to github PR #. I.e. when we merge, it is
> enough just to metnion "fixes #<PR>" to close the PR on the mirror as well.
>
> If we don't want to merge a PR ("won't fix resolution") we'd have to just
> close it on github (I think one has to be a part of "apache" organization
> in github, i suggest to request membership for those who haven't yet done
> so).
>
> Suggested reading
> [1] https://help.github.com/articles/using-pull-requests Some people
> asked how to create github pull requests
> [2] https://help.github.com/articles/merging-a-pull-request see "merging
> locally"
> [3] https://help.github.com/articles/closing-issues-via-commit-messages commit
> messages
>
>
> On Fri, May 23, 2014 at 12:31 PM, Dmitriy Lyubimov <dlie...@gmail.com>wrote:
>
>> Asking INFRA to enable related github integration features, filed
>> as INFRA-7801
>>
>>
>> On Fri, May 23, 2014 at 10:42 AM, Dmitriy Lyubimov <dlie...@gmail.com>wrote:
>>
>>> Aha! apache/mahout github mirror is up!
>>>
>>> let me try and see if i can do and manage a PR there.
>>>
>>> I guess i will still need to file another infra Jira for jira/mailing
>>> list integration features ( we already voted for that in bulk).
>>>
>>>
>>> On Thu, May 22, 2014 at 10:14 AM, Dmitriy Lyubimov <dlie...@gmail.com>wrote:
>>>
>>>> Hi,
>>>>
>>>> (1) git migration of the project is now complete. Any volunteers to
>>>> verify per INFRA-7777? If you do, please report back to the issue.
>>>>
>>>> (2) Anybody knows what to do with jenkins now? i still don't have
>>>> proper privileges on it. thanks.
>>>>
>>>>
>>>>
>>>> [1] https://issues.apache.org/jira/browse/INFRA-7777
>>>>
>>>
>>>
>>
>
