[
https://issues.apache.org/jira/browse/MAHOUT-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014777#comment-14014777
]
Suneel Marthi edited comment on MAHOUT-1505 at 5/31/14 9:45 PM:
----------------------------------------------------------------
Reviewing the patch and few places where the code needs some cleanup:-
1. Since Canopy Clustering has been now marked as @deprecated, please remove
all references and unit tests for Canopy Clustering in TestClusterInterface,
TestClusterDumper and TestClusterClassifier.
2. AbstractClusrer.java
Method formatVectorAsJson() - What are we doing with vectorTerms ? I don't
see that being used anywhere, If vectorTerms is not needed, we may also not
need the static class TermIndexWeight ?
3. Cluster.java - remove the following variable as its never used anywhere in
the code
String CLUSTERED_POINTS_DIR = "clusteredPoints";
was (Author: smarthi):
Reviewing the patch and few places where the code needs some cleanup:-
1. Since Canopy Clustering has been now marked as @deprecated, please remove
all references and unit tests for Canopy Clustering in TestClusterInterface,
TestClusterDumper and TestClusterClassifier.
2. AbstractClusrer.java
Method formatVectorAsJson() - What are we doing with vectorTerms ? If u
don't need vectorTerms, then do we really need the static class TermIndexWeight
?
> structure of clusterdump's JSON output
> --------------------------------------
>
> Key: MAHOUT-1505
> URL: https://issues.apache.org/jira/browse/MAHOUT-1505
> Project: Mahout
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 0.9
> Reporter: Terry Blankers
> Assignee: Andrew Musselman
> Labels: json
> Fix For: 1.0
>
> Attachments: MAHOUT-1505.patch
>
>
> Hi all, I'm working on some automated analysis of the clusterdump output
> using '-of = JSON'. While digging into the structure of the representation of
> the data I've noticed something that seems a little odd to me.
> In order to access the data for a particular cluster, the 'cluster', 'n', 'c'
> & 'r' values are all in one continuous string. For example:
> {noformat}
> {"cluster":"VL-10515{n=5924 c=[action:0.023, adherence:0.223,
> administration:0.011 r=[action:0.446, adherence:1.501,
> administration:0.306]}"}
> {noformat}
> This is also the case for the "point":
> {noformat}
> {"point":"013FFD34580BA31AECE5D75DE65478B3D691D138 = [body:6.904,
> harm:10.101]","vector_name":"013FFD34580BA31AECE5D75DE65478B3D691D138","weight":"1.0"}
> {noformat}
> This leads me to believe that the only way I can get to the individual data
> in these items is by string parsing. For JSON deserialization I would have
> expected to see something along the lines of:
> {noformat}
> {
> "cluster":"VL-10515",
> "n":5924,
> "c":
> [
> {"action":0.023},
> {"adherence":0.223},
> {"administration":0.011}
> ],
> "r":
> [
> {"action":0.446},
> {"adherence":1.501},
> {"administration":0.306}
> ]
> }
> {noformat}
> and:
> {noformat}
> {
> "point": {
> "body": 6.904,
> "harm": 10.101
> },
> "vector_name": "013FFD34580BA31AECE5D75DE65478B3D691D138",
> "weight": 1.0
> }
> {noformat}
> Andrew Musselman replied:
> {quote}
> Looks like a bug to me as well; I would have expected something similar to
> what you were expecting except maybe something like this which puts the "c"
> and "r" values in objects rather than arrays of single-element objects:
> {noformat}
> {
> "cluster":"VL-10515",
> "n":5924,
> "c":
> {
> "action":0.023,
> "adherence":0.223,
> "administration":0.011
> },
> "r":
> {
> "action":0.446,
> "adherence":1.501,
> "administration":0.306
> }
> }
> {noformat}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
