[
https://issues.apache.org/jira/browse/MAHOUT-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097960#comment-14097960
]
ASF GitHub Bot commented on MAHOUT-1500:
----------------------------------------
Github user andrewpalumbo commented on the pull request:
https://github.com/apache/mahout/pull/21#issuecomment-52261287
As far as I can tell, this is just waiting to be merged. The vote has
passed in favor of merging. I've been looking at this a bit over the past
week. I wrote some simple tests for Naive Bayes from M-1493 on top of this and
found that it integrated very easily (as far as writing tests in Math-Scala and
then extending them in h2o and spark test suites).
I'm not familiar with the inner workings of h2o and am new to scala and the
DSL, but the code looks good to me. From what I can see there are a couple of
more (very minor) style points that i've noticed (see above comments). And a
couple of updates that need to be made to get this working against the current
master.
My issue has been with the Java 1.7 h2o-core artifact. I've brought it up
a couple of times, and it seems that its not as much of a problem as I'd
originally thought. I am still a little concerned with tests will fail for
someone running 1.6. Is there a way to get a 1.6 artifact in here? Please
someone let me know if I'm being overly cautious here.
Long story short- looks good to me: +1 from me on merging if we can get
that artifact issue solved (or if it is really a non-issue).
Looking back at the email archive over the past few months, I do share many
of the concerns that have been brought up, Especially regarding documentation
of spark/h20 supported algorithms, and think that we need to get that up
quickly.
Someone with a better working knowledge of h2o and scala/DSL may want to
assign this and review it further and merge. If its just a question simply of
needing someone to assign this to and merging it, I can do it.
> H2O integration
> ---------------
>
> Key: MAHOUT-1500
> URL: https://issues.apache.org/jira/browse/MAHOUT-1500
> Project: Mahout
> Issue Type: Improvement
> Reporter: Anand Avati
> Fix For: 1.0
>
>
> Provide H2O backend for the Mahout DSL
--
This message was sent by Atlassian JIRA
(v6.2#6252)
