[
https://issues.apache.org/jira/browse/MAHOUT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157577#comment-14157577
]
ASF GitHub Bot commented on MAHOUT-1615:
----------------------------------------
GitHub user andrewpalumbo reopened a pull request:
https://github.com/apache/mahout/pull/52
MAHOUT-1615: drmFromHDFS returning the same Key for all Key,Vec Pairs for
Text-Keyed SequenceFiles
SparkContext.sequenceFile(...) will yield the same key per partition for
Text-Keyed Sequence files if the key a new copy of the key is not created when
mapping to an RDD. This patch checks for Text Keys and creates a copy of each
Key if necessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 6adb01ee53ce591962b97a4ed474c111635f7c47
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-14T20:50:50Z
Create copy of Key for Text Keys
commit a81c34000e0152a7ad7349afdba8a9e854380653
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-14T21:11:45Z
use y: Writable instead of y: VectorWritable
commit 2d431a40bd7a62a117487451b3e255c2e56c7d1a
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-14T22:55:34Z
scala not java
commit 5541d500ef8cfb53c9e18da1c760ea8c39dd5409
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-17T19:57:35Z
Read SequenceFile Header to get Key/Value Classes
commit 79468e7a83e7af1f9ab10689b46a900bd463aa38
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-17T19:59:34Z
Use our new method to get the ClassTag
commit ffb40161173df145041cf60d9b2878af3cab911b
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-18T23:07:33Z
Very Clunky use of getKeyClass. This commit solves inital problems. Needs
to be gutted. Hadoop configuration needs to be set up correctly. Spark I/O
DFS tests fail because reader doesnt know weather to read locally or from HDFS
commit 56b5db1b2ee5cdef3700fb9199c75637d5e3b570
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-19T19:10:00Z
Use case matching and val2keyFunc to map rdd
commit 0edeffe30c64e78297335f06516d8cb3ff6b36a3
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-21T21:58:29Z
Cleanup/temporarily hardcode spark kryo buffer property
commit 0d64b0be427998e74cc6d57bf653573b235e0a31
Author: Dmitriy Lyubimov <[email protected]>
Date: 2014-09-22T17:13:15Z
Adding key class tag extraction from checkpointed class;
adding assert to `DRM DFS i/o (local)` test to fail if key class tag is
incorrectly loaded.
temporary commended h20 module since it doesn't compile
commit c63468e10b9ae7e7b0b50728b0d2b71883f894b8
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-22T17:40:20Z
Merge branch 'MAHOUT-1615-drmFromHdfs' of
http://github.com/dlyubimov/mahout into MAHOUT-1615
commit 36b40615619c12dcd7820e7628b3bbf86329bd76
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-22T21:42:29Z
Read a sequence FILE not a directory- like the error says
commit da014759404db1398f8e334e2801b5159e816d56
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-22T21:50:46Z
cleanup
commit b5c3575c7575bc6b1b7b22881895f1a6a21c74ed
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-23T15:37:54Z
Change DFS I/O test to read a specified part-00000 file
commit 4fff4eea3c257ae03f1061eae0cde72013b0aff5
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-23T17:26:02Z
Fix Int and Long key casting test failure
commit 57c0964d0852409e11e6c6ae376ff261db19d3d6
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-24T21:40:02Z
define keyClassTag in h2o
commit 8152bdba666b690249f4cfada7bddf9089fedd11
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-25T15:33:47Z
Switch val2key and key2val, remove val2key
commit a9da184eaa0dc768abf397e97d540d92eaf6fb5b
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-25T20:43:47Z
Throw Exception if not Int, Text or Long Keyed
commit 2a3aaad5ee4319a9a7c5a0d2ee408f704aa603af
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-25T21:19:53Z
Cleanup
commit 8dfa83e0dd72c4dfb86121caf5d6ff0725bc23ee
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-26T18:49:35Z
Add support for Keys of other Writable Types supported By Spark
commit ffc4469c6282b2a303a49032b4b51e4da1c86584
Author: Dmitriy Lyubimov <[email protected]>
Date: 2014-09-26T21:58:08Z
Refactoring hdfs ops
commit 91dc481b45efafdf0c12fdfabcd21be085e6a17e
Author: Dmitriy Lyubimov <[email protected]>
Date: 2014-09-26T22:09:00Z
Fixing h20 build
commit c8d9a93f556d34149598b8b56203110506064f5f
Author: Dmitriy Lyubimov <[email protected]>
Date: 2014-09-26T22:17:17Z
Actually load and write paths should be identical (parent dfs folder, not a
particular partition file)
commit 42296b4bfb327ebd30152299d5ae264f2cd4279b
Author: Dmitriy Lyubimov <[email protected]>
Date: 2014-09-26T22:19:21Z
cosmetic
commit ed46efc36027c2340b2749257266741c26871cf8
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-26T22:28:49Z
Merge pull request #1 from dlyubimov/MAHOUT-1615
Refactoring hdfs ops
commit 7ab50293a409d30313093d070f538d39a0ffa919
Author: Andrew Palumbo <[email protected]>
Date: 2014-09-26T22:37:29Z
Temporarily disable h2o build
commit 9a4d7d2077a5c78b13d06e9bbffce3a78a3ea829
Author: Andrew Palumbo <[email protected]>
Date: 2014-10-02T23:33:30Z
Minor edits for Hadoop 1.2.1 support
----
> SparkEngine drmFromHDFS returning the same Key for all Key,Vec Pairs for
> Text-Keyed SequenceFiles
> -------------------------------------------------------------------------------------------------
>
> Key: MAHOUT-1615
> URL: https://issues.apache.org/jira/browse/MAHOUT-1615
> Project: Mahout
> Issue Type: Bug
> Reporter: Andrew Palumbo
> Assignee: Andrew Palumbo
> Fix For: 1.0
>
>
> When reading in seq2sparse output from HDFS in the spark-shell of form
> <Text,VectorWriteable> SparkEngine's drmFromHDFS method is creating rdds
> with the same Key for all Pairs:
> {code}
> mahout> val drmTFIDF= drmFromHDFS( path =
> "/tmp/mahout-work-andy/20news-test-vectors/part-r-00000")
> {code}
> Has keys:
> {...}
> key: /talk.religion.misc/84570
> key: /talk.religion.misc/84570
> key: /talk.religion.misc/84570
> {...}
> for the entire set. This is the last Key in the set.
> The problem can be traced to the first line of drmFromHDFS(...) in
> SparkEngine.scala:
> {code}
> val rdd = sc.sequenceFile(path, classOf[Writable], classOf[VectorWritable],
> minPartitions = parMin)
> // Get rid of VectorWritable
> .map(t => (t._1, t._2.get()))
> {code}
> which gives the same key for all t._1.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
