[ 
https://issues.apache.org/jira/browse/MAHOUT-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582652#comment-14582652
 ] 

ASF GitHub Bot commented on MAHOUT-1660:
----------------------------------------

Github user andrewmusselman commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/135#discussion_r32277244
  
    --- Diff: 
spark/src/main/scala/org/apache/mahout/sparkbindings/drm/CheckpointedDrmSpark.scala
 ---
    @@ -78,8 +78,8 @@ class CheckpointedDrmSpark[K: ClassTag](
       }
     
       def cache() = {
    -    if (!cached) {
    -      rdd.persist(_cacheStorageLevel)
    +    if (!cached && _cacheStorageLevel != StorageLevel.NONE) {
    --- End diff --
    
    Will this be confusing if someone tries to call cache() with NONE set and 
it's not cached?


> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
> ----------------------------------------------------------
>
>                 Key: MAHOUT-1660
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1660
>             Project: Mahout
>          Issue Type: Bug
>          Components: spark
>    Affects Versions: 0.10.0
>            Reporter: Suneel Marthi
>            Assignee: Dmitriy Lyubimov
>            Priority: Minor
>             Fix For: 0.10.2
>
>
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop configuration from 
> Context and not ignore it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to