yeah I'd say close the PR... I dont think the work on the Jira was ever completed though.. I'm not sure of the priority of that.
On 10/22/2015 12:20 PM, Andrew Musselman wrote: > I don't see any actual stuff in there aside from version updates in poms > and your h2o changes.. > > On Thu, Oct 22, 2015 at 9:17 AM, Andrew Palumbo <[email protected]> wrote: > >> That Haddop1HDFSUtils commit is already in the master. So thats not a >> problem. I'm not sure about the rest of the Guava/google stuff. >> >> On 10/22/2015 12:12 PM, Andrew Musselman wrote: >>> Palumbo: https://issues.apache.org/jira/browse/MAHOUT-1708 and >>> https://github.com/apache/mahout/pull/132/commits >>> >>> Can we close these? >>> >>> On Thu, Oct 22, 2015 at 7:38 AM, Suneel Marthi (JIRA) <[email protected]> >>> wrote: >>> >>>> [ >>>> >> https://issues.apache.org/jira/browse/MAHOUT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969242#comment-14969242 >>>> ] >>>> >>>> Suneel Marthi commented on MAHOUT-1708: >>>> --------------------------------------- >>>> >>>> Is this Jira still needed? >>>> >>>>> Replace Google/Guava in mahout-math and mahout-hdfs >>>>> --------------------------------------------------- >>>>> >>>>> Key: MAHOUT-1708 >>>>> URL: >> https://issues.apache.org/jira/browse/MAHOUT-1708 >>>>> Project: Mahout >>>>> Issue Type: Bug >>>>> Components: Hdfs, Math >>>>> Affects Versions: 0.10.0 >>>>> Environment: Spark >>>>> Reporter: Pat Ferrel >>>>> Assignee: Andrew Musselman >>>>> Fix For: 0.11.1 >>>>> >>>>> >>>>> all use of guava has been removed from the code used with Spark except >>>> the use of Preconditions. These are pretty easy to replace. >>>>> 1) remove guava from mahout-math, mahout-hdfs, poms and the spark >>>> dependency-reduced assembly. >>>>> 2) you will now get compile errors for math and hdfs so remove the >>>> imports and replace and Preconditions with asserts. >>>>> Not sure how many errors in replacing these will be caught with unit >>>> tests so be careful. >>>> >>>> >>>> >>>> -- >>>> This message was sent by Atlassian JIRA >>>> (v6.3.4#6332) >>>> >>
