[ 
https://issues.apache.org/jira/browse/MAHOUT-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227756#comment-15227756
 ] 

ASF GitHub Bot commented on MAHOUT-1823:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/210#discussion_r58652871
  
    --- Diff: 
flink/src/test/scala/org/apache/mahout/flinkbindings/DistributedFlinkSuite.scala
 ---
    @@ -29,8 +34,13 @@ trait DistributedFlinkSuite extends 
DistributedMahoutSuite { this: Suite =>
       protected implicit var mahoutCtx: DistributedContext = _
       protected var env: ExecutionEnvironment = null
     
    +  var cluster: Option[ForkableFlinkMiniCluster] = None
    +  val parallelism = 4
    +  protected val DEFAULT_AKKA_ASK_TIMEOUT: Long = 1000
    +  protected var DEFAULT_TIMEOUT: FiniteDuration = new 
FiniteDuration(DEFAULT_AKKA_ASK_TIMEOUT, TimeUnit.SECONDS)
    +
       def initContext() {
    -    env = ExecutionEnvironment.getExecutionEnvironment
    +//    env = ExecutionEnvironment.getExecutionEnvironment
         // set this higher so that tests like dsqDist(X,Y) have enough 
available slots to pass on a single machine.
         env.setParallelism(10)
    --- End diff --
    
    Shouldn't this setParallelism be removed? 


> Modify MahoutFlinkTestSuite to implement FlinkTestBase
> ------------------------------------------------------
>
>                 Key: MAHOUT-1823
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1823
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Flink
>    Affects Versions: 0.11.2
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>             Fix For: 0.12.0
>
>
> Modify the present MahoutFlinkTestSuite to implement FlinkTestBase. This 
> spins up a FlinkMiniCluster to execute the tests on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to