[
https://issues.apache.org/jira/browse/MAHOUT-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852979#comment-15852979
]
ASF GitHub Bot commented on MAHOUT-1936:
----------------------------------------
Github user andrewpalumbo commented on the issue:
https://github.com/apache/mahout/pull/278
+1 LGTM - Do we have any unit tests for the pipeline?
> FactorMap finds column maximums incorrectly on large data sets
> --------------------------------------------------------------
>
> Key: MAHOUT-1936
> URL: https://issues.apache.org/jira/browse/MAHOUT-1936
> Project: Mahout
> Issue Type: Bug
> Components: Algorithms
> Affects Versions: 0.13.0
> Reporter: Trevor Grant
> Assignee: Trevor Grant
> Fix For: 0.13.0
>
>
> FactorMap's fit method does not properly find the maximum of the column.
> Likely due to an impropper allreduceBlock here
> https://github.com/apache/mahout/blob/master/math-scala/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala#L40
> Also, factorMap in this instance might be more appropriately named "factorMax"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
