andrewpalumbo commented on a change in pull request #394:
URL: https://github.com/apache/mahout/pull/394#discussion_r414097746
##########
File path:
community/community-engines/flink-batch/src/main/scala/org/apache/mahout/flinkbindings/drm/CheckpointedFlinkDrm.scala
##########
@@ -62,17 +62,16 @@ class CheckpointedFlinkDrm[K: ClassTag:TypeInformation](val
ds: DrmDataSet[K],
// this is extra I/O for each cache call. this needs to be moved somewhere
where it is called
// only once. Possibly FlinkDistributedEngine.
- GlobalConfiguration.loadConfiguration(mahoutHome + "/conf/flink-config.yaml")
+ GlobalConfiguration.loadConfiguration(mahoutHome + "/conf/")
Review comment:
verified missing `./conf/flink-config.yaml` :
```
[INFO] Forking ScalaTest via: /bin/sh -c cd
'/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch'
&& 'java'
'-Djava.home=/Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre'
'-Djdk.lang.Process.launchMechanism=FORK'
'-Dmahout.home=/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch/target/test-classes'
'-Dbasedir=/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch'
'-Xmx4g' 'org.scalatest.tools.Runner' '-R'
'/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch/target/classes
/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch/target/test-classes'
'-o' '-fWDF'
'/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch/target/surefire-reports/TestSuite.txt'
'-u'
'/Users/colleenpalumbo/sandbox/mahout/community/community-engines/flink-batch/target/surefire-reports/.'
Discovery starting.
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
Discovery completed in 438 milliseconds.
Run starting. Expected test count is: 114
DrmLikeOpsSuite:
org.apache.mahout.flinkbindings.DrmLikeOpsSuite *** ABORTED ***
org.apache.flink.configuration.IllegalConfigurationException: The Flink
config file '/Users/colleenpalumbo/sandbox/mahout/conf/flink-conf.yaml'
(/Users/colleenpalumbo/sandbox/mahout/conf) does not exist.
at
org.apache.flink.configuration.GlobalConfiguration.loadConfiguration(GlobalConfiguration.java:124)
at org.apache.flink.configuration.```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
