400Ping commented on code in PR #751:
URL: https://github.com/apache/mahout/pull/751#discussion_r2658955167
##########
qdp/qdp-core/src/lib.rs:
##########
@@ -221,38 +228,13 @@ impl QdpEngine {
"Sample size cannot be zero".into(),
));
}
- if sample_size > STAGE_SIZE_ELEMENTS {
- return Err(MahoutError::InvalidInput(format!(
- "Sample size {} exceeds staging buffer capacity {}
(elements)",
- sample_size, STAGE_SIZE_ELEMENTS
- )));
- }
-
- // Reuse a single norm buffer across chunks to avoid per-chunk
allocations.
- //
- // Important: the norm buffer must outlive the async kernels that
consume it.
- // Per-chunk allocation + drop can lead to use-after-free when the
next chunk
- // reuses the same device memory while the previous chunk is still
running.
Review Comment:
hmm, I agree that it is a concern. Will update this into the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
