viiccwen commented on PR #810: URL: https://github.com/apache/mahout/pull/810#issuecomment-3739248962
Looks great! I found current fn `encode` contains repeated 1D / 2D shape-matching logic across NumPy and PyTorch paths, which makes the function grow to ~150+ lines and slightly harder to scan at a glance. Maybe it might be worth refactoring it into small helper functions in a follow-up PR? I don’t think this needs to block the current change, just leaving this as a note for potential future cleanup : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
