viiccwen commented on code in PR #805:
URL: https://github.com/apache/mahout/pull/805#discussion_r2691750983
##########
qdp/qdp-core/tests/preprocessing.rs:
##########
@@ -53,8 +53,8 @@ fn test_validate_input_empty_data() {
#[test]
fn test_validate_input_data_too_large() {
- let data = vec![1.0, 0.0, 0.0]; // 3 elements
- let result = Preprocessor::validate_input(&data, 1); // max size 2^1 = 2
+ let data = vec![1.0, 0.0, 0.0];
+ let result = Preprocessor::validate_input(&data, 1);
Review Comment:
thx for pointing out. I'll undo it later.
##########
qdp/qdp-core/tests/preprocessing.rs:
##########
@@ -63,7 +63,7 @@ fn test_validate_input_data_too_large() {
#[test]
fn test_validate_input_allows_partial_state() {
let data = vec![0.5, -0.5, 0.25];
- assert!(Preprocessor::validate_input(&data, 3).is_ok()); // state vector
can hold up to 8 elements
+ assert!(Preprocessor::validate_input(&data, 3).is_ok());
Review Comment:
thx for pointing out. I'll undo it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
