rich7420 commented on code in PR #916:
URL: https://github.com/apache/mahout/pull/916#discussion_r2724258057
##########
qdp/qdp-kernels/tests/amplitude_encode.rs:
##########
@@ -622,6 +622,52 @@ fn test_l2_norm_batch_kernel_stream() {
println!("PASS: Batched norm reduction on stream matches CPU");
}
+#[test]
+#[cfg(target_os = "linux")]
+fn test_l2_norm_single_kernel_f32() {
Review Comment:
I think maybe we could add a float32 odd-length test to exercise the tail
load path here to cover the offset < input_len branch in the new kernel
(qdp/qdp-kernels/src/amplitude.cu lines 406-409).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
