shiavm006 commented on issue #942: URL: https://github.com/apache/mahout/issues/942#issuecomment-3801252713
> I remember this will never occur in our circumstances? Correct me if I am wrong. but I think overflow can happen in practice. On 32-bit systems, usize MAX is about 4.3 billion. With 20 qubits (state size ~1M) and a batch of ~4K rows, the multiplication can overflow. even if it doesn’t occur today, using .expect() for overflow is brittle it panics instead of returning a Result that callers can handle. TensorFlow reader already handles this with ok_or_else check on (tensorflow.rs lines 84–89), so we should follow the same pattern here for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
