[ 
https://issues.apache.org/jira/browse/CONNECTORS-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974503#comment-13974503
 ] 

Ahmet Arslan commented on CONNECTORS-931:
-----------------------------------------

Only java7 related thing is {{StandardCharsets}} are guaranteed to be available 
on every implementation of the Java platform. With java7 
java.net.URLEncoder.encode(s, StandardCharsets.UTF_8.name()); is guaranteed to 
be UnsupportedEncodingException proof.

I don't have strong feeling about this is related to java7. And I don't know 
whether "utf-8" can throw UnsupportedEncodingException in java 1.6.

I can divide last patch into two. 

Because last patch has 
* "US-ASCII" =>  StandardCharsets.US_ASCII.name()
* "ISO8859-1" => StandardCharsets.ISO_8859_1

And I can create a new jira ticket regarding for remaining parts.




> Cleanup charset handling for Java 7
> -----------------------------------
>
>                 Key: CONNECTORS-931
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-931
>             Project: ManifoldCF
>          Issue Type: Task
>    Affects Versions: ManifoldCF 1.6
>            Reporter: Ahmet Arslan
>             Fix For: ManifoldCF 1.7
>
>         Attachments: CONNECTORS-931.patch, CONNECTORS-931.patch
>
>
> As we are now on Java 7, we should cleanup our charset handling to use the 
> official constants added by Java 7: {{StandardCharsets}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to