[ 
https://issues.apache.org/jira/browse/CONNECTORS-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897158#comment-16897158
 ] 

Michael Cizmar commented on CONNECTORS-1615:
--------------------------------------------

Right.   However, the case is:
 # That processing on the job stops when a single null is returned from the 
result set
 # The error message misinforms the user to the structure of the query and not 
the result

So ManifoldCF could handle 99+% of the result set but fails due to one bad 
record.  This record could come in after the initial configuration.  As I said, 
the message does not direct the user to the root problem.  What I had to do was 
look up the code to see that there was in fact a null check and then find out 
that in row 40k+ there was a null.

The message should say explicitly what failed.  "Null was returned for identity 
column, bad seed query...."

 

 

> Bad Error Message when IDCOLUMN's value is actually null
> --------------------------------------------------------
>
>                 Key: CONNECTORS-1615
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1615
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: JDBC connector
>    Affects Versions: ManifoldCF 2.13
>            Reporter: Michael Cizmar
>            Assignee: Karl Wright
>            Priority: Major
>             Fix For: ManifoldCF 2.14
>
>
> In the edge case that the id column is null, the error message doesn't 
> suggest that.
>  
> {code:java}
> Object o = row.getValue(JDBCConstants.idReturnColumnName);
>       if (o == null)
>       throw new ManifoldCFException("Bad seed query; doesn't return 
> $(IDCOLUMN) column. Try using quotes around $(IDCOLUMN) variable, e.g. 
> \"$(IDCOLUMN)\", or, for MySQL, select \"by label\" in your repository 
> connection.");
>       String idValue = JDBCConnection.readAsString(o);
> {code}
>  
>  
> Also, should it entirely fail if one $IDCOLUMN record is null?



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to