Yes, you can do that. Thanks! Karl
On Tue, Mar 15, 2022 at 2:19 PM Julien Massiera < julien.massi...@francelabs.com> wrote: > Then I'll create a ticket to just add a date to the system.err.println > output of the OOM, is it ok ? > > -----Message d'origine----- > De : Karl Wright <daddy...@gmail.com> > Envoyé : mardi 15 mars 2022 19:10 > À : dev <dev@manifoldcf.apache.org> > Objet : Re: Change way of logging OOM and InterruptedException in > WorkerThread > > (1) InterruptedExceptions are thrown during normal shutdown and should > generally not be logged. This is by design. > (2) OOM conditions can prevent logging from working. So if you want to > log those, fine, but please retain the System.err output. > > Karl > > > On Tue, Mar 15, 2022 at 1:51 PM Julien Massiera < > julien.massi...@francelabs.com> wrote: > > > Hi, > > > > > > > > In the WorkerThread class, OOM are logged using System.err (l849) and > > therefore cannot be formated, but more importantly, the timestamp is > > lost, which can be very problematic to investigate issues. Also, > > InterruptedExceptions are not logged at all (l844) ! > > > > Can we use Logging.threads.fatal for OOM and Logging.threads.error > > for InterruptedExceptions instead ? > > > > > > > > If it is ok, I can create a ticket and make the changes myself. > > > > > > > > Regards, > > > > Julien > > > > > > > > > > > > > >
