Committed, and the unit tests pass. Thank you! I will create a release artifact this weekend and schedule a vote for release. In the meantime, if it works for you, feel free to give it a try and report any difficulties.
Karl On Tue, Aug 23, 2022 at 6:41 AM Wolfinger Uwe <uwe.wolfin...@oegk.at> wrote: > Done > > > > > > -----Ursprüngliche Nachricht----- > Von: Karl Wright <daddy...@gmail.com> > Gesendet: Dienstag, 23. August 2022 12:24 > An: dev <dev@manifoldcf.apache.org> > Betreff: Re: MCF Solr Plugin for Solr 9.x > > You need to be a committer to have write access, but you can attach a > patch to a ticket. The patch is generated most easily with "svn diff > >patch.txt" > or some such. Here's the JIRA ticket: > https://issues.apache.org/jira/browse/CONNECTORS-1723 > > Karl > > > On Tue, Aug 23, 2022 at 4:57 AM Wolfinger Uwe <uwe.wolfin...@oegk.at> > wrote: > > > It turned out that the uprade was pretty straight forward. > > > > Beginning with version 9 of solr org.apache.solr.core.CloseHook > > changed from an abstract class to an interface, i.e. CloseHandler now > > has to implement CloseHook instead of extending it. Build and local > > tests passed without any problems. > > > > Source (v. 1.0-SNAPSHOT) would now be ready for further tests. How > > should i commit the source code (do i have write access to the repo)? > > > > Kind regards, > > Uwe > > > > > > -----Ursprüngliche Nachricht----- > > Von: Karl Wright <daddy...@gmail.com> > > Gesendet: Freitag, 19. August 2022 13:11 > > An: dev <dev@manifoldcf.apache.org> > > Betreff: Re: MCF Solr Plugin for Solr 9.x > > > > All set up. Here's the SVN url: > > https://svn.apache.org/repos/asf/manifoldcf/integration/solr-9.x/trunk . > > Please provide patches as needed to get this to build and test. Or if > > this is beyond the level of technical expertise you have, I'll see if > > I can interest anyone on the dev team to have a look. > > > > Karl > > > > > > On Fri, Aug 19, 2022 at 6:58 AM Karl Wright <daddy...@gmail.com> wrote: > > > > > I would love to support Solr 9.x, and I am happy to do the release > > > work and branch setup etc. But we need someone willing to figure > > > out what changed between 8.x and 9.x and make the appropriate > > > changes to the > > code. > > > I've got limited time these days so perhaps we can collaborate? > > > I'll set up the 9.x plugin branch if you would like to research the > > > API > > changes. > > > > > > Karl > > > > > > > > > On Fri, Aug 19, 2022 at 3:25 AM Wolfinger Uwe > > > <uwe.wolfin...@oegk.at> > > > wrote: > > > > > >> I am just upgrading our Solr/ManifoldCF system. During the upgrade > > >> process i tried to raise Solr to version 9.0.0. Unfortunately this > > >> results in the following error, caused by the ManifoldCF Solr > > >> Plugin > > >> (apache-manifoldcf-solr-8.x-plugin-2.2.jar): > > >> > > >> Caused by: java.lang.IncompatibleClassChangeError: class > > >> org.apache.solr.mcf.ManifoldCFSearchComponent$CloseHandler has > > >> interface org.apache.solr.core.CloseHook as super class > > >> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?] > > >> at java.lang.ClassLoader.defineClass(ClassLoader.java:1017) > > ~[?:?] > > >> at > > >> java.security.SecureClassLoader.defineClass(SecureClassLoader.java: > > >> 17 > > >> 4) > > >> ~[?:?] > > >> at > > >> java.net.URLClassLoader.defineClass(URLClassLoader.java:550) > > >> ~[?:?] > > >> at java.net.URLClassLoader$1.run(URLClassLoader.java:458) > ~[?:?] > > >> at java.net.URLClassLoader$1.run(URLClassLoader.java:452) > ~[?:?] > > >> at java.security.AccessController.doPrivileged(Native > > >> Method) ~[?:?] > > >> at > > >> java.net.URLClassLoader.findClass(URLClassLoader.java:451) > > >> ~[?:?] > > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:589) > ~[?:?] > > >> at > > >> java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:899) > > >> ~[?:?] > > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:522) > ~[?:?] > > >> at > > >> org.apache.solr.mcf.ManifoldCFSearchComponent.inform(ManifoldCFSear > > >> ch > > >> Component.java:345) > > >> ~[?:?] > > >> at > > >> org.apache.solr.core.SolrResourceLoader.inform(SolrResourceLoader.j > > >> av > > >> a:722) > > >> ~[solr-core-9.0.0.jar:9.0.0 > > >> a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26 > > >> - janhoy - 2022-05-05 01:00:08] > > >> at org.apache.solr.core.SolrCore.<init>(SolrCore.java:1155) > > >> ~[solr-core-9.0.0.jar:9.0.0 > > >> a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26 > > >> - janhoy - 2022-05-05 01:00:08] > > >> at org.apache.solr.core.SolrCore.<init>(SolrCore.java:1048) > > >> ~[solr-core-9.0.0.jar:9.0.0 > > >> a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26 > > >> - janhoy - 2022-05-05 01:00:08] > > >> at > > >> org.apache.solr.core.CoreContainer.createFromDescriptor(CoreContain > > >> er > > >> .java:1560) > > >> ~[solr-core-9.0.0.jar:9.0.0 > > >> a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26 > > >> - janhoy - 2022-05-05 01:00:08] > > >> at > > >> org.apache.solr.core.CoreContainer.lambda$load$10(CoreContainer.java: > > >> 950) > > >> ~[solr-core-9.0.0.jar:9.0.0 > > >> a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26 > > >> - janhoy - 2022-05-05 01:00:08] > > >> at > > >> com.codahale.metrics.InstrumentedExecutorService$InstrumentedCallab > > >> le > > >> .call(InstrumentedExecutorService.java:202) > > >> ~[metrics-core-4.1.5.jar:4.1.5] > > >> ... 5 more > > >> > > >> At the moment, ManifoldCF Solr plugins are available up to Solr > > >> version 8 > > >> > > >> Is there a plan, to create a solr-9x plugin version in order to > > >> support solr versions >=9 ? > > >> > > >> Kind regards, > > >> Uwe > > >> > > > > > >
