[ 
https://issues.apache.org/jira/browse/MARMOTTA-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691672#comment-13691672
 ] 

Peter Ansell commented on MARMOTTA-260:
---------------------------------------

There is also a bug in the logic for RdfJsonParser right now:

            if(subjectKey.startsWith(HTTP)) {
                subject = new URIImpl(subjectKey);
            } else {
                subject = new BNodeImpl(subjectKey);
            }

should be similar to:

            if(subjectKey.startsWith("_:")) {
                subject =getValueFactory().createBNode(subjectKey.substring(2));
            } else {
                subject = getValueFactory().createURI(subjectKey);
            }

Directly calling the URIImpl and BNodeImpl constructors is not as useful (or 
accurate in terms of bnode identity management) as reusing the ValueFactory 
that is specified.
                
> Remove sesame-tools-rio-rdfjson in favour of sesame-rio-rdfjson
> ---------------------------------------------------------------
>
>                 Key: MARMOTTA-260
>                 URL: https://issues.apache.org/jira/browse/MARMOTTA-260
>             Project: Marmotta
>          Issue Type: Improvement
>          Components: Sesame Tools
>            Reporter: Peter Ansell
>            Assignee: Sebastian Schaffert
>
> I wrote a streaming Jackson based RDF/JSON parser (sesame-rio-rdfjson) that 
> could be used as a replacement for the sesame-tools-rio-rdfjson parser. 
> There is also a writer, which also uses Jackson, but doesn't use the same 
> method as the current writer implementation. Feel free to contrast the two 
> writing methods if the current sesame-rio-rdfjson is not as performant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to