Sure, I will submit another PR after we are done with https://github.com/apache/incubator-marvin/pull/25
On Wed, Jun 5, 2019 at 6:40 AM Lucas Bonatto Miguel <[email protected]> wrote: > Hi Wei, I agree with your suggestion. Having the dockers at the root folder > would make more sense since there are dependencies between our projects. > > Could you send an MR doing this change? > > - Lucas > > On Sun, Jun 2, 2019 at 12:23 PM Wei Chen <[email protected]> wrote: > > > Hello All, > > > > In our Dockerfile, we include both the engine jar file and the > > python-toolbox.tgz > > > > Means that the build should be a larger set to the engine and toolbox. > > However, these builds are currently placed inside the engine folder. > > > > > https://github.com/apache/incubator-marvin/tree/develop/engine-executor/build > > > > > > I will argue that we should place it in the root folder. > > > > Did anyone get an opinion with this? > > > > Best Regards > > Wei > > >
