Hello Everyone, On second thought, I think I will merge the PR#25 first. We can handle the bin file history after we are good with the sonatype artifact. If everyone is good with that, I will merge it tomorrow.
Best Regards Wei On Wed, Jun 19, 2019 at 2:18 PM Wei Chen <weic...@apache.org> wrote: > Hello All, > > While waiting for the artifact set up on the sonatype server, > I think we can revert the history of the filename change first. > (which is currently part of the PR#25 > https://github.com/apache/incubator-marvin/pull/25) > > One reason why we didn't move on with the PR is that I am waiting for the > artifact to decide whether we should also remove the history of 2 bin files. > marvin-engine-server-assembly.jar > <https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/marvin-engine-server-assembly.jar> > python-toolbox.tgz > <https://github.com/apache/incubator-marvin/blob/develop/engine-executor/build/python-toolbox.tgz> > > After all, I think we all agree that we shouldn't keep the bin file in the > repo to minimize the size of the repo, as we should also clear of the > history of it for faster cloning. > > Therefore, I will work out a new PR to remove the history of all rename > files plus these 2 bin files. > > Is everyone OK with that? > > Best Regards > Wei >
