Thanks. I made a topic to discuss how I can proceed with the MR. I agree with the error type too, will include in proto code.
Best regards, Em qui., 14 de mai. de 2020 às 15:14, Lucas Bonatto Miguel < lucasb...@apache.org> escreveu: > That's a good initiative. > > I agree that we must make auth optional, and IMO it should be something > that comes in a later stage. Maybe you just make sure your interface would > be able to receive an authentication implementation in the future, but I > don't think that is something that needs to be implemented right now. At > the end of the day there are several ways one can workaround the lack of > authentication at this level of an architecture. > > One suggestion I have is to include an Error type to the proto, so that we > have a pre-defined way of returning exceptions. > > Are you planning to create an issue and MR for it? > > Best, > > On Fri, May 8, 2020 at 9:27 AM Lucas Cardoso Silva < > cardosolucas61....@gmail.com> wrote: > > > I believe that we must keep both options. For develop in a controlled > > environment, the insecure server option is easier. But gRPC has several > > authentication methods. The best and easiest to implement, in my opinion, > > is SSL / TLS. The user can generate his own keys and pass it to the > modules > > to establish a connection. > > > > https://grpc.io/docs/guides/auth/#with-server-authentication-ssltls-4 > > > > Em sex., 8 de mai. de 2020 às 02:24, Wei Chen <weic...@apache.org> > > escreveu: > > > > > One question, should we include authentication information into the > proto > > > spec? > > > > > > On Fri, May 8, 2020 at 10:35 AM Lucas Cardoso Silva < > > > cardosolucas61....@gmail.com> wrote: > > > > > > > I did a grpc implementation for the daemon, as discussed earlier. I > > would > > > > like to know your opinion about this code. To complete the changes, > > only > > > a > > > > user interface module would be missing, which I can do until the > > > beginning > > > > of next week. All unit tests have also been adapted and the daemon > has > > a > > > > code coverage of 70%, but I will try to improve this coverage before > > > > commit. Thanks in advance. > > > > > > > > Proto: > > > > > https://gist.github.com/cardosolucas/49b8afa0767dd98b39f25365a0371bb4 > > > > Server: > > > > > https://gist.github.com/cardosolucas/e20855ce82e27526d976781cb46a6d1d > > > > > > > > Best regards, > > > > Lucas Cardoso > > > > > > > > > >
