Hearing no objections.... this change is checked in now.
Thanks,
Tom
-----Forwarded Message-----
> From: Tom Copeland <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: A proposed change to the PMD plugin....
> Date: 16 Jun 2003 15:58:09 -0400
>
> ....I'd like to check in a change to
> maven/src/plugins-build/pmd/plugin.properties - I'd like to reduce the
> standard set of rulesets to basic.xml, unusedcode.xml, and imports.xml.
>
> Here's why - right now the PMD plugin runs every ruleset that PMD has.
> This includes rulesets that have conflicting rules - for example, the
> controversial.xml ruleset has one rule that requires every class have at
> least one constructor and another rule that looks for unnecessary
> constructors. So by running every rule in the controversial ruleset,
> you're guaranteed to get a bunch of rule violations no matter what you
> do.
>
> I'd have simply checked this in, but I haven't been active in Maven for
> a while and wanted to make sure I wasn't hosing anything up first.
> Here's a patch for what I'd like to check in:
>
> =================
> [EMAIL PROTECTED] pmd]$ cvs diff plugin.properties
> Index: plugin.properties
> ===================================================================
> RCS file: /home/cvs/maven/src/plugins-build/pmd/plugin.properties,v
> retrieving revision 1.2
> diff -r1.2 plugin.properties
> 14c14
> <
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/strings.xml,${plugin.resources}/rulesets/junit.xml,${plugin.resources}/rulesets/braces.xml,${plugin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/design.xml,${plugin.resources}/rulesets/naming.xml,${plugin.resources}/rulesets/imports.xml,${plugin.resources}/rulesets/codesize.xml
> ---
> >
> maven.pmd.rulesetfiles=${plugin.resources}/rulesets/basic.xml,${plugin.resources}/rulesets/unusedcode.xml,${plugin.resources}/rulesets/imports.xml
> [EMAIL PROTECTED] pmd]$
> =================
>
> If no one has any objections, I'll check this updated plugins.properties
> in in a little while...
>
> Thanks much,
>
> Tom
> --
> Tom Copeland <[EMAIL PROTECTED]>
> InfoEther
--
Tom Copeland <[EMAIL PROTECTED]>
InfoEther
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
