Sorry! I'll try to be clearer next time. 
I will also fix/improve those comments

It was a fix for Issue#518

regards
Michal

> -----Original Message-----
> From: Vincent Massol [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, July 01, 2003 11:52 AM
> To: 'Maven Developers List'
> Subject: RE: cvs commit: maven/src/plugins-build/war/xdocs changes.xml
> 
> Hi Michal,
> 
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> > Sent: 01 July 2003 10:44
> > To: [EMAIL PROTECTED]
> > Subject: cvs commit: maven/src/plugins-build/war/xdocs changes.xml
> 
> [snip]
> 
> >   Index: changes.xml
> >   ===================================================================
> >   RCS file: /home/cvs/maven/src/plugins-build/war/xdocs/changes.xml,v
> >   retrieving revision 1.4
> >   retrieving revision 1.5
> >   diff -u -r1.4 -r1.5
> >   --- changes.xml   13 Apr 2003 02:35:12 -0000      1.4
> >   +++ changes.xml   1 Jul 2003 08:43:51 -0000       1.5
> >   @@ -11,6 +11,12 @@
> >          <action dev="dion" type="fix" due-to="Ben Hogan">
> >            Allow war file to be updated
> >          </action>
> >   +      <action dev="michal" type="fix">
> >   +        Iterating artifacts not depedencies
> >   +      </action>
> 
> Can you please explain better in changes.xml why you did that (the
> reason for it)? There are also some typos: "Iterating over artifacts"
> and "dependencies".
> 
> Also, I think the rule is to have new changes added first in the list so
> that the list always contains the latest changes first.
> 
> Thanks
> -Vincent
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to