dion 2003/07/28 16:55:14
Modified: src/java/org/apache/maven/jelly/tags/werkz
MavenAttainGoalListener.java
Log:
Comments on implementation
Revision Changes Path
1.2 +4 -1
maven/src/java/org/apache/maven/jelly/tags/werkz/MavenAttainGoalListener.java
Index: MavenAttainGoalListener.java
===================================================================
RCS file:
/home/cvs/maven/src/java/org/apache/maven/jelly/tags/werkz/MavenAttainGoalListener.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- MavenAttainGoalListener.java 27 Jul 2003 23:33:58 -0000 1.1
+++ MavenAttainGoalListener.java 28 Jul 2003 23:55:14 -0000 1.2
@@ -117,12 +117,14 @@
if ( goalName.startsWith( "postGoal" ) )
{
+ // FIXME: This magic belongs in plugin manager.
String id = getJellyScriptHousingId( goalName );
JellyScriptHousing h =
pluginManager.getMapper().getPostGoalJellyScriptHousing( id );
pluginContext = pluginManager.createPluginContext( h, getBaseContext()
);
}
else if ( goalName.startsWith( "preGoal") )
{
+ // FIXME: This magic belongs in plugin manager.
String id = getJellyScriptHousingId( goalName );
JellyScriptHousing h =
pluginManager.getMapper().getPreGoalJellyScriptHousing( id );
pluginContext = pluginManager.createPluginContext( h, getBaseContext()
);
@@ -140,6 +142,7 @@
Project plugin = (Project) pluginContext.getVariable( "plugin" );
String pluginId = Project.standardToLegacyId( plugin.getId() );
+ // FIXME: Plugins shouldn't have to have "-plugin" in their id
if ( pluginId.indexOf( "-plugin" ) > 0 )
{
// We start with names like maven-java-plugin, but that's annoying to
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
