dion 2003/07/28 17:05:44
Modified: src/java/org/apache/maven/plugin PluginManager.java
Log:
Some comments and marking some methods as private.
We need a private/public visibility recap on all public classes before 1.0
Revision Changes Path
1.50 +10 -4 maven/src/java/org/apache/maven/plugin/PluginManager.java
Index: PluginManager.java
===================================================================
RCS file: /home/cvs/maven/src/java/org/apache/maven/plugin/PluginManager.java,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- PluginManager.java 28 Jul 2003 00:02:59 -0000 1.49
+++ PluginManager.java 29 Jul 2003 00:05:44 -0000 1.50
@@ -178,6 +178,7 @@
mapper = new GoalToJellyScriptHousingMapper();
+ // FIXME: Why are there two hard coded class loaders?
rootClassLoader = Forehead.getInstance().getClassLoader( "root" );
mavenRootClassLoader = Forehead.getInstance().getClassLoader( "root.maven"
);
@@ -188,16 +189,20 @@
// Accessors
// ----------------------------------------------------------------------
- public Maven getMaven()
+ private Maven getMaven()
{
return maven;
}
- public void setMaven( Maven maven )
+ private void setMaven( Maven maven )
{
this.maven = maven;
}
+ /**
+ * @todo Why is this method public?
+ * @return
+ */
public GoalToJellyScriptHousingMapper getMapper()
{
return mapper;
@@ -211,6 +216,7 @@
* Initialize all plugins.
*
* @throws Exception If an error occurs while initializing any plugin.
+ * @todo why is this method public/
*/
public void initialize()
throws Exception
@@ -226,7 +232,7 @@
File[] files = getPluginsDir().listFiles();
// First we expand any JARs that contain plugins to the unpack directory.
- // This will be a different directory than the plugin jars
+ // This will be a different directory than the plugin jars if
// MAVEN_HOME_LOCAL / maven.home.local was set to a different directory
// than MAVEN_HOME / maven.home.
for ( int i = 0; i < files.length; ++i )
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
