Hi Michal, My $.02 worth... I'm biased towards invoking xdoclet, however, which is a slightly different focus than Brian (I think) so my replies may not be 100% compatible with yours.
> Hi Brian! > > I don't like the idea of making fatter ejb:plugin > and putting there a logic which is particular to some application > server. > > IMHO the correct workflow which should be supported by ejb plugin looks > like follows: > > a) gather all the files which will be packaged in ejb-jar in one place > (equivalent of war:webapp) > b) archive this directory (equivalent of war:war) > > > Now other plugins like xdoclet/jboss/websphere/whatever I'm not seeing any plugins that invoke xdoclet's <ejbdoclet> tag. I really think it makes sense to have an ejb:ejbdoclet goal in the ejb plugin to invoke that. Why? A couple of reasons: a) Because it can generate code for multiple appservers it doesn't make sense to invoke it in a container-specific plugin. b) I suppose we could create a maven-xdoclet-plugin to do the invocation but, really, <ejbdoclet> is *only* for generating the ejb-related files so IMO it just makes sense that it would be a part of the ejb plugin. > > Will be able to easily run pre/post goals for steps "a" and "b" and > decorate them accordingly to their needs > > And those plugins can deliver higher level methods like: > > jboss:ejb weblogic:ejb > > which will create ejb jar for jboss/weblogic and reuse maven-ejb plugin In my experience (using only jboss and weblogic) there's not really a difference in the ejb jar creation process. There *is* a difference in some of the files contained in there but those are (typically) generated by xdoclet or hand-coded into src/ejb/foo. > > So basically maven-ejb plugin IMHO should be used as a tag library which > can be extended/overridden and should not contain container specific > logic. I hope to submit (to jira) my ejb:ejbdoclet goal today. I would appreciate your thoughts on whehter or not its appropriate for the ejb plugin or, if not, where it might make sense to be. > > > Also properties like: > maven.ejb.support.0.includes > > are not really compatible with other properties used in maven. > Only plugin which uses them which I am aware of is auto-generated > xdoclet plugin > And it uses them because ... it is auto-generated. > I am rather against them. > > regards > > Michal > Thanks, James --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
